Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitUntilReady is currently broken. #1607

Closed
iocanel opened this issue Jun 28, 2019 · 3 comments · Fixed by #1638
Closed

WaitUntilReady is currently broken. #1607

iocanel opened this issue Jun 28, 2019 · 3 comments · Fixed by #1638
Labels

Comments

@iocanel
Copy link
Member

iocanel commented Jun 28, 2019

Using something like:

  client.resourceList(list).waitUntilReady(config.getReadinessTimeout(), TimeUnit.MILLISECONDS);

This worked great until 4.1.0 but seems broken in 4.2.0 as it seems to return immediately.

@iocanel
Copy link
Member Author

iocanel commented Jul 1, 2019

For anyone interested in fixing this there are 3 issues:

  1. waitUntilReady delegates to waitUntilExists which is just wrong.
  2. The item should be get from server each time the predicate is check.
  3. Readiness.isReady() will through Exception if resource doesn't somehow support the concept of readiness and the rest of the code doesn't seem to support it.

All 3 are regressions introducted in the period 4.1.0 to 4.2.0

rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jul 18, 2019
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Aug 5, 2019
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Aug 6, 2019
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 17, 2019
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 26, 2019
@stale
Copy link

stale bot commented Sep 29, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Sep 29, 2019
@tombentley
Copy link
Contributor

Not stale. I see @rohanKanojia is working on a fix, which is great.

@stale stale bot removed the status/stale label Sep 30, 2019
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants