Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRD generator doesn't properly add renamed properties to required list #3431

Closed
metacosm opened this issue Aug 30, 2021 · 0 comments · Fixed by #3415
Closed

CRD generator doesn't properly add renamed properties to required list #3431

metacosm opened this issue Aug 30, 2021 · 0 comments · Fixed by #3415
Assignees
@metacosm
Labels
bug
Milestone
5.7.1

Comments

@metacosm
Copy link
Collaborator

The CRD generator currently doesn't account for renamed properties when checking for required field: the field will always be added with the original name without taking any potential overrides.
@metacosm metacosm added the bug label Aug 30, 2021
@metacosm metacosm added this to the 5.8.0 milestone Aug 30, 2021
@metacosm metacosm self-assigned this Aug 30, 2021
metacosm added a commit that referenced this issue Aug 30, 2021
@metacosm
fix: enum values / required list should honor JsonProperty annotations
6316fa5 
Fixes #3411
Fixes #3431
metacosm added a commit that referenced this issue Aug 30, 2021
@metacosm
fix: enum values / required list should honor JsonProperty annotations
ff9ef03 
Fixes #3411
Fixes #3431
@metacosm metacosm mentioned this issue Aug 30, 2021
Merged
11 tasks
@snowdrop-bot snowdrop-bot mentioned this issue Aug 30, 2021
Closed
metacosm added a commit that referenced this issue Aug 30, 2021
@metacosm
fix: enum values / required list should honor JsonProperty annotations
ade2693 
Fixes #3411
Fixes #3431
@manusa manusa modified the milestones: 5.8.0, 5.7.1 Sep 1, 2021
manusa pushed a commit that referenced this issue Sep 1, 2021
@metacosm @manusa
fix: enum values / required list should honor JsonProperty annotations
625229b 
Fixes #3411
Fixes #3431
@deepsan deepsan mentioned this issue Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
bug
Projects
None yet
Milestone
5.7.1
Development

Successfully merging a pull request may close this issue.

fix: enum values should honor JsonProperty annotations fabric8io/kubernetes-client
2 participants
@metacosm @manusa