-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit resourceVersion and locking behavior #4861
Comments
Discussed on a call. The most straight-forward action would be to deprecate the current replace and createOrReplace methods and the usage of lock related to replace. This will also help move away from the situations where a put / json patch leads to invalid states that we current compensate for - modifyItemForReplaceOrPatch which is used for Services, Jobs, and RoleBindings - as users will be directed towards logic that doesn't need to compensate. Beyond the deprecations we would do:
|
Is your task related to a problem? Please describe
There are several paradigms that the fabric8 client uses wrt to resourceVersions - which are not all entirely consistent.
Describe the solution you'd like
We should try to make things as consistent as possible, and/or follow the behavior of kubectl. That could mean either expanding / formalizing the notion of locking, or removing it - with documentation on what leaving the resourceVersion populated on an item does.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: