-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLFromIngressImpl doesn't consider Ingress in networking.k8s.io
apiGroup
#4906
Comments
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 27, 2023
… in `networking.k8s.io` apiGroup (fabric8io#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
11 tasks
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 27, 2023
… in `networking.k8s.io` apiGroup (fabric8io#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 28, 2023
… in `networking.k8s.io` apiGroup (fabric8io#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 28, 2023
… in `networking.k8s.io` apiGroup (fabric8io#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 28, 2023
… in `networking.k8s.io` apiGroup (fabric8io#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 28, 2023
… in `networking.k8s.io` apiGroup (fabric8io#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 28, 2023
… in `networking.k8s.io` apiGroup (fabric8io#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
manusa
pushed a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Mar 2, 2023
… in `networking.k8s.io` apiGroup (fabric8io#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
manusa
pushed a commit
that referenced
this issue
Mar 3, 2023
… in `networking.k8s.io` apiGroup (#4906) URLFromIngressImpl should handle `networking.k8s.io/v1` Ingress well. Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In #1139, we had implemented a getURL() method to fetch Service URL from different sources like OpenShift Routes, Ingresses, Service NodePort etc.
However, at that time Ingress was only available in
extensions/v1beta1
apiGroup. As Kubernetes moved forward Ingress was moved tonetworking.k8s.io
apigroups (first inv1beta1
and then inv1
).URLFromIngressImpl doesn't seem to account for new apiGroups for Ingress
kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/impl/URLFromIngressImpl.java
Lines 36 to 40 in a1111ad
Fabric8 Kubernetes Client version
SNAPSHOT
Steps to reproduce
Run ServiceExample on a latest Kubernetes Cluster, you'll get error regarding
extensions/v1beta1
apigroup not foundtheExpected behavior
KubernetesClient should resolve
networking.k8s.io
Ingress as well in URLFromIngressImplRuntime
Kubernetes (vanilla)
Kubernetes API Server version
1.25.3@latest
Environment
Linux
Fabric8 Kubernetes Client Logs
Here are logs from running ServiceExample:
Additional context
No response
The text was updated successfully, but these errors were encountered: