Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HttpClient.Factory instances can be prioritized #4811

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 31, 2023

Description

Introduce a scoring system so that HttpClient.Factory instances provided by the SPI can be prioritized.
The higher the priority, the higher the chances
that the factory instance will be selected automatically to create HttpClient instances.

Relates to quarkusio/quarkus#30480

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Introduce a scoring system so that HttpClient.Factory instances
provided by the SPI can be prioritized.
The higher the priority, the higher the chances
that the factory instance will be selected automatically
to create HttpClient instances.

Signed-off-by: GitHub <[email protected]>
@manusa manusa modified the milestones: 6.4.0, 6.4.1 Jan 31, 2023
@manusa manusa self-assigned this Jan 31, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.2% 69.2% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 5ffca33 into fabric8io:6.4 Jan 31, 2023
@manusa manusa deleted the refctor/kubernetes-builder-scoring branch January 31, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants