fix #4924: handles non-okhttp clients with invalid watch status #4928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In trying to run the other clients against the kubernetes-tests, WatchTest had a failure - responding with 200, null was actually providing the literal "null" result. This is not seen by the okhttp logic because it doesn't provide the response to websocket request exceptions, but we do for the other client types. Treating this as a status creates a null value and ensuing NPE - but that is swallowed by the current exception handling. These changes make everything appropriately defensive.
Type of change
test, version modification, documentation, etc.)
Checklist