Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4924: handles non-okhttp clients with invalid watch status #4928

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

shawkins
Copy link
Contributor

Description

In trying to run the other clients against the kubernetes-tests, WatchTest had a failure - responding with 200, null was actually providing the literal "null" result. This is not seen by the okhttp logic because it doesn't provide the response to websocket request exceptions, but we do for the other client types. Treating this as a status creates a null value and ensuing NPE - but that is swallowed by the current exception handling. These changes make everything appropriately defensive.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins changed the title fix #4924: handles non-jdk clients with invalid watch status fix #4924: handles non-okhttp clients with invalid watch status Mar 1, 2023
@manusa manusa added this to the 6.5.0 milestone Mar 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

57.1% 57.1% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit ddafb6d into fabric8io:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants