Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test : Update CronJobIT to use batch/v1 CronJob instead(#4434) #5019

Merged
merged 1 commit into from
Apr 3, 2023
Merged

test : Update CronJobIT to use batch/v1 CronJob instead(#4434) #5019

merged 1 commit into from
Apr 3, 2023

Conversation

rohanKanojia
Copy link
Member

Description

Fix #4434

Update CronJobIT to use io.fabric8.kubernetes.api.model.batch.v1.CronJob instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rohanKanojia rohanKanojia marked this pull request as ready for review March 31, 2023 16:51
shawkins
shawkins approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa added this to the 6.6.0 milestone Apr 3, 2023
@manusa manusa merged commit 47e6411 into fabric8io:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@shawkins shawkins shawkins approved these changes

@oscerd oscerd oscerd approved these changes

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

Update CronJobIT integration test to use CronJob v1 instead
4 participants
@rohanKanojia @manusa @shawkins @oscerd