Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimizing debug logs related to the backoff interval #5080

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

shawkins
Copy link
Contributor

Description

Removing the log in the calculator and relying on surrounding logs. If needed we can add a debug / trace log to the Utils.schedule method.

cc @csviri

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa requested a review from metacosm April 27, 2023 07:39
@manusa
Copy link
Member

manusa commented Apr 27, 2023

Since the log entry was added by @metacosm, adding him as a reviewer.

I don't mind removing the log entry, or maybe just switching it to a trace (I'd prefer this option). However, I don't think this addresses the issue @csviri was reporting in yesterday's internal meeting.

To note, there are logs in the dependent classes:

LOG.debug("HTTP operation on url: {} should be retried as the response code was {}, retrying after {} millis",

  • Changes in this PR to the AbstractWatchManager to include info about the reconnection

  • Missing in Reflector, but would likely duplicate what was added to the AbstractWatchManager in this class

@manusa manusa added this to the 6.6.0 milestone Apr 27, 2023
@manusa manusa merged commit de7bc54 into fabric8io:master Apr 27, 2023
manusa added a commit to manusa/kubernetes-client that referenced this pull request Apr 27, 2023
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little late but LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants