Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent runtime issues when running with Vert.x HTTP client in native mode #5085

Merged
merged 1 commit into from
Apr 29, 2023
Merged

fix: prevent runtime issues when running with Vert.x HTTP client in native mode #5085

merged 1 commit into from
Apr 29, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Apr 28, 2023

Description

fix: prevent runtime issues when running with Vert.x HTTP client in native mode

/cc @metacosm @geoand

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 6.6.0 milestone Apr 28, 2023
@manusa manusa self-assigned this Apr 28, 2023
@metacosm
Copy link
Collaborator

Can you please check this as well, @vietj?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@metacosm
Copy link
Collaborator

It would be good to get a quick fix because this is currently blocking further testing of the client in native mode.

@manusa manusa merged commit a044fca into fabric8io:master Apr 29, 2023
@manusa manusa deleted the fix/native-runtime branch April 29, 2023 05:28
@metacosm
Copy link
Collaborator

Thank you for the quick turn around! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@shawkins shawkins Awaiting requested review from shawkins

@sunix sunix Awaiting requested review from sunix

Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manusa @metacosm @geoand @rohanKanojia