Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5126: fallback to changeit only if null/empty does not work #5131

Merged
merged 3 commits into from
May 25, 2023
Merged

fix #5126: fallback to changeit only if null/empty does not work #5131

merged 3 commits into from
May 25, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented May 15, 2023 •
edited by rohanKanojia
Loading

Description

Fix #5126
Addresses #5126 by using changeit as a last chance, rather than as a replacement for null/empty.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins force-pushed the iss5126 branch 3 times, most recently from c343d3a to 6cc5d9a Compare May 15, 2023 20:48
@manusa manusa self-assigned this May 25, 2023
manusa
manusa reviewed May 25, 2023
View reviewed changes
kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/internal/CertUtils.java Outdated
// last chance, try changeit
if ((passphrase == null || passphrase.length == 0) && ex.getCause() instanceof UnrecoverableKeyException) {
try (FileInputStream fis1 = new FileInputStream(fileToLoad)) {
keyStore.load(fis1, passphrase);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not falling back

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

55.1% 55.1% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.7.0 milestone May 25, 2023
@manusa manusa merged commit 5fb4ea8 into fabric8io:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@sunix sunix Awaiting requested review from sunix

Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.

NULL pass phrase SHOULD NOT be replaced with "changeit"
3 participants
@shawkins @manusa @rohanKanojia