chore(TS): migrate Group and ActiveSelectin (#8455)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [next]
 
+- chore(TS): migrate Group/ActiveSelection [#8455](https://github.com/fabricjs/fabric.js/pull/8455)
 - fix(TS): migration error of itext key mixin (#8421) [#8457](https://github.com/fabricjs/fabric.js/pull/8457)
 - chore(TS): migrate text classes/mixins [#8421](https://github.com/fabricjs/fabric.js/pull/8421)
 - chore(TS): migrate Image [#8443](https://github.com/fabricjs/fabric.js/pull/8443)

src/__types__.ts

@@ -19,4 +19,3 @@ export type StaticCanvas = Record<string, any> & {
   };
   getRetinaScaling(): number;
 } & Observable;
-export type TObject = any;

src/brushes/circle_brush.class.ts

@@ -3,15 +3,11 @@ import { Color } from '../color';
 import { Point } from '../point.class';
 import { Shadow } from '../shadow.class';
 import { Circle } from '../shapes/circle.class';
+import { Group } from '../shapes/group.class';
 import { getRandomInt } from '../util/internals';
 import { Canvas } from '../__types__';
 import { BaseBrush } from './base_brush.class';
 
-/**
- * @todo remove transient
- */
-const { Group } = fabric;
-
 export type CircleBrushPoint = {
   x: number;
   y: number;

src/brushes/spray_brush.class.ts

@@ -1,16 +1,12 @@
 import { fabric } from '../../HEADER';
 import { Point } from '../point.class';
+import { Group } from '../shapes/group.class';
 import { Shadow } from '../shadow.class';
 import { Rect } from '../shapes/rect.class';
 import { getRandomInt } from '../util/internals';
 import { Canvas } from '../__types__';
 import { BaseBrush } from './base_brush.class';
 
-/**
- * @todo remove transient
- */
-const { Group } = fabric;
-
 export type SprayBrushPoint = {
   x: number;
   y: number;

src/cache.ts

@@ -47,7 +47,6 @@ export class Cache {
    * measurement and so wrong bounding boxes.
    * After the font cache is cleared, either change the textObject text content or call
    * initDimensions() to trigger a recalculation
-   * @memberOf fabric.util
    * @param {String} [fontFamily] font family to clear
    */
   clearFontCache(fontFamily?: string) {
@@ -62,7 +61,6 @@ export class Cache {
   /**
    * Given current aspect ratio, determines the max width and height that can
    * respect the total allowed area for the cache.
-   * @memberOf fabric.util
    * @param {number} ar aspect ratio
    * @return {number[]} Limited dimensions X and Y
    */

src/mixins/collection.mixin.ts

@@ -1,7 +1,9 @@
 import { fabric } from '../../HEADER';
 import type { FabricObject } from '../shapes/fabricObject.class';
 
-export function createCollectionMixin(Klass: { new (...args: any[]): any }) {
+export function createCollectionMixin<T extends { new (...args: any[]): any }>(
+  Klass: T
+) {
   return class Collection extends Klass {
     /**
      * @type {FabricObject[]}
@@ -123,7 +125,7 @@ export function createCollectionMixin(Klass: { new (...args: any[]): any }) {
     /**
      * Returns true if collection contains an object.\
      * **Prefer using {@link `FabricObject#isDescendantOf`} for performance reasons**
-     * instead of a.contains(b) use b.isDescendantOf(a)
+     * instead of `a.contains(b)` use `b.isDescendantOf(a)`
      * @param {Object} object Object to check against
      * @param {Boolean} [deep=false] `true` to check all descendants, `false` to check only `_objects`
      * @return {Boolean} `true` if collection contains an object
@@ -133,7 +135,9 @@ export function createCollectionMixin(Klass: { new (...args: any[]): any }) {
         return true;
       } else if (deep) {
         return this._objects.some(
-          (obj) => obj instanceof Collection && obj.contains(object, true)
+          (obj) =>
+            obj instanceof Collection &&
+            (obj as unknown as Collection).contains(object, true)
         );
       }
       return false;

src/pattern.class.ts

@@ -83,7 +83,6 @@ export class Pattern {
    * Constructor
    * @param {Object} [options] Options object
    * @param {option.source} [source] the pattern source, eventually empty or a drawable
-   * @return {fabric.Pattern} thisArg
    */
   constructor(options: TPatternOptions = {}) {
     this.id = FabricObject.__uid++;