Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths in path created not cleared properly when removing all objects. #5814

Closed
niels-van-den-broeck opened this issue Jul 22, 2019 · 4 comments · Fixed by #5866
Closed

Paths in path created not cleared properly when removing all objects. #5814

niels-van-den-broeck opened this issue Jul 22, 2019 · 4 comments · Fixed by #5866
Labels
bug

Comments

@niels-van-den-broeck
Copy link
Contributor

niels-van-den-broeck commented Jul 22, 2019 •
edited
Loading

Version

Upgrading from 3.2.0 to ^3.3.0

Test Case

https://codesandbox.io/s/vigilant-ptolemy-n2ztg

Information about environment

browser

Which browsers?
All

Steps to reproduce

Open sandbox and alternate between v3.2.0 and 3.3.0.
Draw a couple of paths

Expected Behavior

No black paths remain. All paths are red.

Actual Behavior

In 3.3.0 the last black path remains, but is not listed in the canvas objects
@niels-van-den-broeck niels-van-den-broeck changed the title path:created: Unexpected breaking change in minor version Paths in path created not cleared properly when removing all objects. Jul 22, 2019
@niels-van-den-broeck
Copy link
Contributor Author

Possibly having issues with an object which remains on the upper-canvas?

@asturur
Copy link
Member

asturur commented Jul 22, 2019

definitely something broke.

@asturur asturur added the bug label Jul 22, 2019
@niels-van-den-broeck
Copy link
Contributor Author

Have been searching a bit yesterday. Totally oblivious as to what is happening

@niels-van-den-broeck
Copy link
Contributor Author

@asturur Wondering if there were any updates on this?

valentintintin added a commit to GroupeCurious/ngx-image-drawing that referenced this issue Aug 8, 2019
@valentintintin
⬆️ Upgrading dependencies and fix FabricJS to 3.2.0 due to bug
54744de 
fabricjs/fabric.js#5814
@niels-van-den-broeck niels-van-den-broeck mentioned this issue Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE 5814: Paths in path created not cleared properly when removing all objects.
2 participants
@asturur @niels-van-den-broeck