Add more generic font families to FabricText.genericFonts

[elohmeier]

Extends the list of genericFonts based on https://developer.mozilla.org/en-US/docs/Web/CSS/font-family#generic-name.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[asturur]

Hi @elohmeier is this fixing some kind of issue you where having? can you elaborate a bit more?

[elohmeier]

Yes, since the font declaration will encapsulate the font name without this change in quotes ("system-ui" instead of system-ui), this leads failing font resolution, at least in Firefox on macOS.

Before the change:

normal 600 16px "system-ui"

After the change:

normal 600 16px system-ui

See also https://developer.mozilla.org/en-US/docs/Web/CSS/font-family#generic-name. We should probably add all the other generic font names as well.

I'm currently monkey-patching this using fabric.FabricText.genericFonts.push("system-ui"); after importing fabric.

[asturur]

Yes please add all generic names, if they have to be 'not quoted' as the specs say, we should have that working.

[asturur]

Also add a changelog line please

[elohmeier]

Thanks for your feedback, I've updated the PR accordingly.