refactor(): Properly include the text on a path hack into the dimensions calculations. still an hack

[asturur]

Description

Make so that the text on a path inside a group looks less broken

Warning

This update could disrupt apps with text on a path that do not use center/center as origin.
This update make text on a path object a bit bigger to properly include text.

This before was done at cache level but not at object dimension level, leaving the text outside the bounding box.
While this was working ok for single object and a bit of padding it was wrong and it didn't work when text was in side a group.

Fabric 5 is considered not more developed and deprecated.
This fix and the next one are shipped into a minor version update 5.5. If you heavily depend on text on a path and you didn't find any bug till now, just don't move to 5.5.

V6 is getting an entirely differen treatment for text on a path.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.39 |    77.39 |   86.25 |   83.11 |                                               
 fabric.js |   83.39 |    77.39 |   86.25 |   83.11 | ...,30573-30638,30761,30860,31079,31121-31123 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.39 |    77.38 |   86.25 |   83.11 |                                               
 fabric.js |   83.39 |    77.38 |   86.25 |   83.11 | ...,30573-30638,30761,30860,31079,31121-31123 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.39 |    77.38 |   86.25 |   83.11 |                                               
 fabric.js |   83.39 |    77.38 |   86.25 |   83.11 | ...,30573-30638,30761,30860,31079,31121-31123 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.39 |    77.38 |   86.25 |   83.11 |                                               
 fabric.js |   83.39 |    77.38 |   86.25 |   83.11 | ...,30573-30638,30761,30860,31079,31121-31123 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.39 |    77.38 |   86.25 |   83.11 |                                               
 fabric.js |   83.39 |    77.38 |   86.25 |   83.11 | ...,30573-30638,30761,30860,31079,31121-31123 
-----------|---------|----------|---------|---------|-----------------------------------------------