-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update itext_key_behavior.mixin.js #1616
Update itext_key_behavior.mixin.js #1616
Conversation
@kangax |
Better behaviour of selection with keyboard. Now you can cross from select direction LEFT to RIGHT and back.
Improved text selection with keyboard, you can cross selection start with up and down now. |
Sorry, i missed that.
33: 'moveCursorUp', | ||
34: 'moveCursorDown', | ||
35: 'moveCursorRight', | ||
36: 'moveCursorLeft', | ||
37: 'moveCursorLeft', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are both 36 and 37 moveCursorLeft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two moveCursorLeft, two moveCursorRight, two moveCursorUp, two moveCursorDown.
You defined functions for moving the cursor for the arrow keys, and then with the help of CMD button ( metakey ) you use the same functions to go to: start of text, end of text, start of line, end of line.
I bind home, end, pgUp and pgDown keys to those functions ( not having a cmd button on my laptop ) and i obtain the same functions.
Hey @sorich87, could you please test this? Would really appreciate it. |
did someone give it a quick look? other than new functions it stops that square rendering in firefox.
|
I tested on a US keyboard and it works fine. I wanted to test on a FR keyboard too before replying but haven't had a chance yet. |
Beside working correctly, do you like the behaving of selection when crossing selectionstart and / or the new keys functionality? For locales i wouldnt bother, tab esc pgup down, end home have the same keycodes since forever. |
2 similar comments
Beside working correctly, do you like the behaving of selection when crossing selectionstart and / or the new keys functionality? For locales i wouldnt bother, tab esc pgup down, end home have the same keycodes since forever. |
Beside working correctly, do you like the behaving of selection when crossing selectionstart and / or the new keys functionality? For locales i wouldnt bother, tab esc pgup down, end home have the same keycodes since forever. |
Yes, it's great! I couldn't test home and end though (Mac OS X). |
Please create new tag with this fix. Cannot use fixed version with bower. |
Added behaviour for keys pagUP ,pagDOWN , HOME, END, TAB and ESC. ( mimic meta key, that on windows i don't know where it is )
Removed rendering of squares in firefox.