Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for null shadow #2181

Closed
wants to merge 1 commit into from
Closed

fix for null shadow #2181

wants to merge 1 commit into from

Conversation

sapics
Copy link
Contributor

@sapics sapics commented May 9, 2015

This PR fix error Uncaught TypeError: Cannot read property 'affectStroke' of null

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@asturur
Copy link
Member

asturur commented May 9, 2015

ok this is my fresh error of yesterday.
so dumb.

i m sorry i did not use stroke on my tests. will be more carefull.

@asturur
Copy link
Member

asturur commented May 9, 2015

i removed it because inside the remove shadow function we do the same check again.

@asturur
Copy link
Member

asturur commented May 9, 2015

@sapics sorry i have to submit 2 PRs both conflicting with this.
I copy your fix in my PR for text and for object class, otherwise is complicated to merge

@sapics
Copy link
Contributor Author

sapics commented May 9, 2015

@asturur I see! Is it better to close?

@kangax kangax closed this in #2182 May 10, 2015
@sapics sapics deleted the fix-null-shadow branch May 10, 2015 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants