Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm reserved keyword char #5782

Merged
merged 2 commits into from
Jun 29, 2019
Merged

Rm reserved keyword char #5782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d59669d
Rm reserved keyword char
pimpin Jun 26, 2019
b5781ce
Update text.class.js
asturur Jun 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/shapes/text.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@
* possibly overridden to accommodate different measure logic or
* to hook some external lib for character measurement
* @private
* @param {String} char to be measured
* @param {String} _char, char to be measured
* @param {Object} charStyle style of char to be measured
* @param {String} [previousChar] previous char
* @param {Object} [prevCharStyle] style of previous char
Expand Down Expand Up @@ -679,12 +679,12 @@

/**
* Computes height of character at given position
* @param {Number} line the line number
* @param {Number} char the character number
* @param {Number} line the line index number
* @param {Number} _char the character index number
* @return {Number} fontSize of the character
*/
getHeightOfChar: function(line, char) {
return this.getValueOfPropertyAt(line, char, 'fontSize');
getHeightOfChar: function(line, _char) {
return this.getValueOfPropertyAt(line, _char, 'fontSize');
},

/**
Expand Down