-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fill-opacity on Path objects with gradients. #5812
Conversation
As soon this is corrected and merged i can look in the geometry problem. |
I am uncomfortable with this latest patch, because I have changed the API to fabric.Gradient.fromElement: specifically, the second argument has become the third, and the opacity attribute has become the second attribute. Feel free to reject (again) if you would rather the new opacity attribute be appended to the end of the arguments to preserve API. |
I agree that would be better to preserve the argument order, even if fromElement is supported just for internal use for the whole SVG parser. |
i will add you svg example as a visual test ( that will probably fail for now ) |
* Implement fill-opacity on Path objects with gradients. * Reorder fabric.Gradient.fromElement arguments.
This fixes the smaller issue in #5810 . That said, I'm not sure I put the test in the right place. It took me longer than I would've liked just to craft a test that works.
Please review with a bit of caution, and if the test is in the wrong place, please provide a better test for the right file. (I'm still quite an amateur at the fabric.js codebase.)