Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): 5.x Disable offscreen check for bg and overlay when not needed #8896

Merged
merged 8 commits into from
May 7, 2023

Conversation

asturur
Copy link
Member

@asturur asturur commented May 7, 2023

Motivation

this issue #8887 points out that the current overlap between those 2 features is not working as expect.

A background or an overlay that does not move with the viewport is never offscreen.

closes #8887

Changes

An object used as background or overlay , with overlayVpt or backgroundVpt set as false will always be rendered regardless of the vpt.
If the developer place it offscreen on purpose or by mistake, it will pay a render cost.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.48 |    77.33 |   86.34 |    83.2 |                                               
 fabric.js |   83.48 |    77.33 |   86.34 |    83.2 | ...,30328,30453,30533-30598,30721,30820,31037 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.48 |    77.31 |   86.34 |    83.2 |                                               
 fabric.js |   83.48 |    77.31 |   86.34 |    83.2 | ...,30328,30453,30533-30598,30721,30820,31037 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.5 |    77.41 |   86.34 |   83.23 |                                               
 fabric.js |    83.5 |    77.41 |   86.34 |   83.23 | ...,30328,30453,30533-30598,30721,30820,31037 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.5 |    77.41 |   86.34 |   83.23 |                                               
 fabric.js |    83.5 |    77.41 |   86.34 |   83.23 | ...,30328,30453,30533-30598,30721,30820,31037 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.5 |    77.41 |   86.34 |   83.23 |                                               
 fabric.js |    83.5 |    77.41 |   86.34 |   83.23 | ...,30328,30453,30533-30598,30721,30820,31037 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.5 |    77.41 |   86.34 |   83.23 |                                               
 fabric.js |    83.5 |    77.41 |   86.34 |   83.23 | ...,30328,30453,30533-30598,30721,30820,31037 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit 3251c46 into 5.x May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant