Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting insecure content from secure context blocks request #31

Open
crianonim opened this issue Jul 19, 2019 · 2 comments
Open

Requesting insecure content from secure context blocks request #31

crianonim opened this issue Jul 19, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@crianonim
Copy link

Your API urls have http as their protocol. This is fine when testing as localhost is also insecured http. However when you serve your content from https (like GitHub Pages) the browser will block it.

This makes pictures not to appear sometimes.

It affects you urls:

var kanyeGiphyCall =  "http://api.giphy.com/v1/gifs/search?api_key=yulIkLnLqFVIDmUCNqd8nYSbprM6tvN0&q=kanye";

var trumpGiphyCall = "http://api.giphy.com/v1/gifs/search?api_key=yulIkLnLqFVIDmUCNqd8nYSbprM6tvN0&q=trump";

If you just added s to http that should be enough (I checked that giphy can serve https content)

If you are curious about what is going on, please read:

https://developers.google.com/web/fundamentals/security/prevent-mixed-content/fixing-mixed-content

@crianonim crianonim added the bug Something isn't working label Jul 19, 2019
@jackbridger
Copy link
Collaborator

Fantastic issue, thank you for taking the time to share a solution and an explanation

emaggy added a commit that referenced this issue Jul 19, 2019
@emaggy emaggy mentioned this issue Jul 19, 2019
@crianonim
Copy link
Author

Always glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants