Add count_only_trials_with_data to trial-based TCs
#3012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64617987 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
- Coverage 95.82% 95.82% -0.01%
==========================================
Files 503 503
Lines 50809 50811 +2
==========================================
+ Hits 48690 48691 +1
- Misses 2119 2120 +1 ☔ View full report in Codecov by Sentry. |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Nov 5, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Nov 6, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Differential Revision: D64617987
mgarrard
force-pushed
the
export-D64617987
branch
from
86ad2b9 to
c0ac309
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64617987 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Nov 6, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 4, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 5, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 5, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 5, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Differential Revision: D64617987
mgarrard
force-pushed
the
export-D64617987
branch
from
c0ac309 to
179155d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64617987 |
mgarrard
force-pushed
the
export-D64617987
branch
from
179155d to
0b2ce16
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 6, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
|
This pull request was exported from Phabricator. Differential Revision: D64617987 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 6, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 6, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 6, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
force-pushed
the
export-D64617987
branch
from
0b2ce16 to
abb812e
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 6, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
|
This pull request was exported from Phabricator. Differential Revision: D64617987 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 8, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 8, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 9, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 9, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 9, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 9, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 9, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Dec 9, 2024
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not Reviewed By: lena-kashtelyan Differential Revision: D64617987
mgarrard
force-pushed
the
export-D64617987
branch
from
abb812e to
859211d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64617987 |
|
This pull request has been merged in 5b5b646. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For some GenerationStrategies we only want to progress if the trials in the expected statuses also actually have data, this extends trial based criterion to consider if we have data or not
Differential Revision: D64617987