Refactor _get_trial_indices_to_fetch #3086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66045355 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3086 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 498 498
Lines 50518 50523 +5
=======================================
+ Hits 48388 48393 +5
Misses 2130 2130 ☔ View full report in Codecov by Sentry. |
paschai
force-pushed
the
export-D66045355
branch
from
cb423d5 to
9a98ad8
Compare
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Nov 25, 2024
Summary: This diff refactors the _get_trial_indices_to_fetch method to improve its readability and maintainability. The changes include: 1. Extracting a new method _identify_trial_indices_to_fetch that takes both old and new trial statuses as input 2. Simplifying the logic for identifying newly completed, running, and previously completed trials with new data after completion. 3. Improving code organization and reducing duplication Differential Revision: D66045355
|
This pull request was exported from Phabricator. Differential Revision: D66045355 |
paschai
force-pushed
the
export-D66045355
branch
from
9a98ad8 to
15a8576
Compare
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 5, 2024
Summary: This diff refactors the _get_trial_indices_to_fetch method to improve its readability and maintainability. The changes include: 1. Extracting a new method _identify_trial_indices_to_fetch that takes both old and new trial statuses as input 2. Simplifying the logic for identifying newly completed, running, and previously completed trials with new data after completion. 3. Improving code organization and reducing duplication Differential Revision: D66045355
|
This pull request was exported from Phabricator. Differential Revision: D66045355 |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 5, 2024
Summary: This diff refactors the _get_trial_indices_to_fetch method to improve its readability and maintainability. The changes include: 1. Extracting a new method _identify_trial_indices_to_fetch that takes both old and new trial statuses as input 2. Simplifying the logic for identifying newly completed, running, and previously completed trials with new data after completion. 3. Improving code organization and reducing duplication Differential Revision: D66045355
paschai
force-pushed
the
export-D66045355
branch
from
15a8576 to
d7f3683
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66045355 |
Summary: This diff refactors the _get_trial_indices_to_fetch method to improve its readability and maintainability. The changes include: 1. Extracting a new method _identify_trial_indices_to_fetch that takes both old and new trial statuses as input 2. Simplifying the logic for identifying newly completed, running, and previously completed trials with new data after completion. 3. Improving code organization and reducing duplication Reviewed By: lena-kashtelyan Differential Revision: D66045355
paschai
force-pushed
the
export-D66045355
branch
from
d7f3683 to
a695daf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66045355 |
|
This pull request has been merged in ec08fe5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D66045355