Move telemetry out of OSS ax #3089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66239268 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3089 +/- ##
==========================================
- Coverage 95.49% 95.41% -0.08%
==========================================
Files 504 493 -11
Lines 50404 49812 -592
==========================================
- Hits 48131 47530 -601
- Misses 2273 2282 +9 ☔ View full report in Codecov by Sentry. |
danielcohenlive
force-pushed
the
export-D66239268
branch
from
29f22b6 to
230f5c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66239268 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3089 It currently isn't providing value in OSS and preventing us from reflecting non OSS features Reviewed By: mpolson64 Differential Revision: D66239268
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3089 It currently isn't providing value in OSS and preventing us from reflecting non OSS features Reviewed By: mpolson64 Differential Revision: D66239268
danielcohenlive
force-pushed
the
export-D66239268
branch
from
230f5c8 to
a98f605
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66239268 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66239268 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3089 It currently isn't providing value in OSS and preventing us from reflecting non OSS features Reviewed By: mpolson64 Differential Revision: D66239268
danielcohenlive
force-pushed
the
export-D66239268
branch
from
a98f605 to
b8c9c4c
Compare
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 2, 2024
Summary: Pull Request resolved: facebook#3089 It currently isn't providing value in OSS and preventing us from reflecting non OSS features Reviewed By: mpolson64 Differential Revision: D66239268
danielcohenlive
force-pushed
the
export-D66239268
branch
from
b8c9c4c to
b2fc137
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66239268 |
Summary: Pull Request resolved: facebook#3089 It currently isn't providing value in OSS and preventing us from reflecting non OSS features Reviewed By: mpolson64 Differential Revision: D66239268
|
This pull request was exported from Phabricator. Differential Revision: D66239268 |
danielcohenlive
force-pushed
the
export-D66239268
branch
from
b2fc137 to
c6c45b6
Compare
|
This pull request has been merged in c821ac5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It currently isn't providing value in OSS and preventing us from reflecting non OSS features
Differential Revision: D66239268