Add delrelativize transform to EBAshr #3314
Closed
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There was a bug that popped up recently that danielcohenlive noticed related to SOO exp not being able to generate candidates. This experiment ended up having a relative constraint in the opt config, which looks like we overlooked. We add that here Differential Revision: D69221574
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69221574 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3314 +/- ##
==========================================
- Coverage 95.74% 95.74% -0.01%
==========================================
Files 533 533
Lines 52513 52516 +3
==========================================
+ Hits 50280 50282 +2
- Misses 2233 2234 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 01c6a73. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There was a bug that popped up recently that danielcohenlive noticed related to SOO exp not being able to generate candidates. This experiment ended up having a relative constraint in the opt config, which looks like we overlooked. We add that here
Differential Revision: D69221574