Merge pull request #107 from facebookincubator/disable_async_validati…

…on_for_builtins Disable async validation for builtins
facebook · Dec 17, 2019 · 1c4812c · 1c4812c
2 parents 3988fc1 + c40ae9a
commit 1c4812c
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/testslide/mock_callable.py b/testslide/mock_callable.py
@@ -597,7 +597,12 @@ def _validate_patch(
                     )
                 if (
                     coroutine_function
-                    and not inspect.iscoroutinefunction(template_value)
+                    and (
+                        # FIXME We can not reliably introspect coroutine functions
+                        # for builtins: https://bugs.python.org/issue38225
+                        type(template_value) is not type(list.append)
+                        and not inspect.iscoroutinefunction(template_value)
+                    )
                     and not callable_returns_coroutine
                 ):
                     raise ValueError(
@@ -640,7 +645,12 @@ def _validate_patch(
                 )
             if (
                 coroutine_function
-                and not inspect.iscoroutinefunction(original_callable)
+                and (
+                    # FIXME We can not reliably introspect coroutine functions
+                    # for builtins: https://bugs.python.org/issue38225
+                    type(original_callable) is not type(list.append)
+                    and not inspect.iscoroutinefunction(original_callable)
+                )
                 and not callable_returns_coroutine
             ):
                 raise ValueError(