Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constructor level type checks + tests #303

Closed
wants to merge 1 commit into from
Closed

constructor level type checks + tests #303

wants to merge 1 commit into from

Conversation

EricLiclair
Copy link
Contributor

What:

Fix for issue #233

  1. Added Constructor level input type checks for various Matchers.

Why:

How:

For point 1
Checked for the passed arguments to be of the specified types. If not, raised a ValueError with appropriate error message.

Risks:

N/A. At least not intentionally.

Checklist:

  • Added tests, if you've added code that should be tested
  • Updated the documentation, if you've changed APIs
  • Ensured the test suite passes
  • Made sure your code lints
  • Completed the Contributor License Agreement ("CLA")

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 21, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 863458086

  • 36 of 36 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 94.145%
Totals Coverage Status
Change from base Build 794246688: 0.08%
Covered Lines: 2605
Relevant Lines: 2767
💛 - Coveralls

@EricLiclair EricLiclair mentioned this pull request May 21, 2021
Closed
5 tasks
@facebook-github-bot
Copy link

@deathowl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@deathowl merged this pull request in aa4a514.

@deathowl
Copy link
Member

Thanks for your PR @EricLiclair, merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EricLiclair @coveralls @facebook-github-bot @deathowl