[HMA] Remove ISignalTypeConfigStore from HMA #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mackay-Fisher
changed the title
Mackay-Fisher
force-pushed
the
Issue-1689-CLI-Storage-Move
branch
2 times, most recently
from
281084a to
3ccba3d
Compare
Dcallies
requested changes
Dec 18, 2024
Comment on lines
2
to
29
|
|
||
| """ | ||
| Common interface for persisting pytx configuration and concepts. | ||
|
|
||
| Most of the individual components of pytx are find to use piecemeal, and | ||
| the full interface covers the most complex and complete useage. A usecase | ||
| with one collection of hashes using one algorithm might be better off | ||
| hardcoding those things rather than fully implementing the interface. | ||
|
|
||
| # Migration Notes | ||
| There's an earlier attempt at these interfaces used for CLI at | ||
| <@Mackay-Fisher add the right pointer to the CLI storage>. | ||
| During the development of Hasher-Matcher-Actioner 2.0 | ||
| (github.com/facebook/ThreatExchange/tree/main/hasher-matcher-actioner/) | ||
| we realized that the original attempt at this wouldn't meet the needs | ||
| of that code and wrote a new interface. | ||
|
|
||
| As of 12/2024, we are now migrating that interface from HMA into pytx | ||
| proper as part of a migration to dbm | ||
| (github.com/facebook/ThreatExchange/issues/1687). The general approach is: | ||
| 1. Copy the interface unchanged from HMA to pytx | ||
| 2. Release a new version of pytx | ||
| 3. Delete the copy in HMA and update all references to the pytx version | ||
|
|
||
| In parallel, we intend to slowly migrate the CLI storage components to | ||
| follow the same interface. | ||
| """ | ||
|
|
There was a problem hiding this comment.
blocking: This comment is useful, why delete it?
Comment on lines
2
to
29
|
|
||
| """ | ||
| Common interface for persisting pytx configuration and concepts. | ||
|
|
||
| Most of the individual components of pytx are find to use piecemeal, and | ||
| the full interface covers the most complex and complete useage. A usecase | ||
| with one collection of hashes using one algorithm might be better off | ||
| hardcoding those things rather than fully implementing the interface. | ||
|
|
||
| # Migration Notes | ||
| There's an earlier attempt at these interfaces used for CLI at | ||
| <@Mackay-Fisher add the right pointer to the CLI storage>. | ||
| During the development of Hasher-Matcher-Actioner 2.0 | ||
| (github.com/facebook/ThreatExchange/tree/main/hasher-matcher-actioner/) | ||
| we realized that the original attempt at this wouldn't meet the needs | ||
| of that code and wrote a new interface. | ||
|
|
||
| As of 12/2024, we are now migrating that interface from HMA into pytx | ||
| proper as part of a migration to dbm | ||
| (github.com/facebook/ThreatExchange/issues/1687). The general approach is: | ||
| 1. Copy the interface unchanged from HMA to pytx | ||
| 2. Release a new version of pytx | ||
| 3. Delete the copy in HMA and update all references to the pytx version | ||
|
|
||
| In parallel, we intend to slowly migrate the CLI storage components to | ||
| follow the same interface. | ||
| """ | ||
|
|
There was a problem hiding this comment.
blocking: This comment is useful, why delete it?
Mackay-Fisher
force-pushed
the
Issue-1689-CLI-Storage-Move
branch
from
991e870 to
2b26523
Compare
…e and then updated imports through threat exchange after version update
Mackay-Fisher
force-pushed
the
Issue-1689-CLI-Storage-Move
branch
from
df93168 to
6fca94d
Compare
Dcallies
added a commit
that referenced
this pull request
Dec 20, 2024
#1724 moves more things around
Dcallies
added a commit
that referenced
this pull request
Dec 20, 2024
#1724 moves more things around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves the 3rd part of issue #1689
Delete ISignalTypeConfigStore in HMA
In HMA, import ISignalTypeConfigStore from pytx to be included in IUnifiedStore
Test Plan
I was not entirely sure what to test to verify. There was a module issue, so I added the init py to allow for the module usage in HMA. I am not sure if that was the correct approach however that is the pr referenced in #1725
Update: Yay the version change worked!