Skip to content

Commit

Permalink
Revert D64465025: Multisect successfully blamed "D64465025: make_py_p…
Browse files Browse the repository at this point in the history
…ackage: don't mutate dep_artifacts" for one test failure

Summary:
This diff reverts D64465025
D64465025: make_py_package: don't mutate dep_artifacts by zsol causes the following test failure:

Tests affected:
- [cogwheel:cogwheel_101_test#main](https://www.internalfb.com/intern/test/562949974597406/)

Here's the Multisect link:
https://www.internalfb.com/multisect/12332686
Here are the tasks that are relevant to this breakage:
T204263932: Some tests failing for cogwheel

The backout may land if someone accepts it.

If this diff has been generated in error, you can Commandeer and Abandon it.

Reviewed By: justintrudell

Differential Revision: D64477010

fbshipit-source-id: 81c6c27bbbc3bed0e86f7e0dd7ccf6772881ab32
  • Loading branch information
generatedunixname89002005232357 authored and facebook-github-bot committed Oct 16, 2024
1 parent 33c0470 commit c5dde14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion prelude/python/make_py_package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ def _pex_modules_args(
if pex_modules.compile:
pyc_mode = PycInvalidationMode("UNCHECKED_HASH") if symlink_tree_path == None else PycInvalidationMode("CHECKED_HASH")
bytecode_manifests = pex_modules.manifests.bytecode_manifests(pyc_mode)
dep_artifacts = dep_artifacts + [a[0] for a in pex_modules.manifests.bytecode_artifacts_with_paths(pyc_mode)]
dep_artifacts.extend([a[0] for a in pex_modules.manifests.bytecode_artifacts_with_paths(pyc_mode)])

bytecode_manifests_path = ctx.actions.write(
"__bytecode_manifests{}.txt".format(output_suffix),
Expand Down

0 comments on commit c5dde14

Please sign in to comment.