Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo): un-fork and update tonic to 0.9.2 #182

Closed

Conversation

thoughtpolice
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2023
@stepancheg stepancheg requested a review from krallin April 19, 2023 01:53
@facebook-github-bot
Copy link
Contributor

@krallin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@krallin
Copy link
Contributor

krallin commented Apr 19, 2023

FYI, it will likely take a bit of time to land this. We'll want to keep the Tonic version we use in the OSS build in sync with our internal build, but this breaking change means we'll have to do quite a bit of updating first:

hyperium/tonic#1274

@thoughtpolice
Copy link
Contributor Author

Ah, in that case I'll close this for now; it can just happen later!

@thoughtpolice thoughtpolice deleted the aseipp/update-tonic branch April 19, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants