Skip to content

latest

Pre-release
Pre-release
Compare
Choose a tag to compare
@github-actions github-actions released this 13 Apr 15:18
· 0 commits to c755dc088b5fc15b65f7b5537c34f7a90b228e2c since this release
Limited the bxl executing threads

Summary:
d16r reported that in bxl resolve a lot of anon targets, bxl will stuck. It is because of we use `block_in_place` for eval bxl, dynamic target, and anon targets. And we will also call `block_on` for each api that will access dice, like `query`, `configured_target_node`, etc. When handling a lot of anon target, it will exceed the tokio  thread pool limit. In d16r case, when it creates 511 anon target, it will stuck.

 {F1974276542}

This diff limited the number of threads running eval anon target and dynamic output in bxl using semaphore.

Reviewed By: JakobDegen

Differential Revision: D68041699

fbshipit-source-id: f8f98a1e7f35baf2278dfc8f74fe5b604fc86e24