-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow start script #302
Comments
Wow, a minute? 😮 Is there anything unusual about your setup? Could you put some logs in its source and check where it’s spending the time? Could it be that a lot of ports after 3000 are busy on your computer for some reason? |
I'm pretty sure I have a vanilla setup. The problem is on this line: My understanding is that the If I change this to The network stuff is out the scope of my knowledge.. Not sure what the implications are if this was just hardcoded to something like If anyone else is having this problem on OS X, easy fix is disconnect from your network and run start. |
To note, I have the same experience. ❯ create-react-app --version ❯ npm -v ❯ node -v ❯ uname -ra |
Just a little diagnostic. ❯ npm i detect-port -g This takes about 1 minute to execute. It looks like if you have the OSX firewall enabled it will cause the long lag. I disabled the OSX firewall and it returns instantly. |
Thanks, this is very valuable info! Can you check if the fix in #302 (comment) also works for you? |
Yea also long startup and I also have firewall enabled.
|
@philstrong Does the fix in #302 (comment) work for you? |
I can reproduce this by turning on the firewall and enabling “block all incoming connections”. |
Yes it does fix the issue @gaearon |
OK, I’ll test this on Windows and release a patch today if it works cross platform. |
This fixes #302 by temporarily forking `detect-port`. Hopefully this fix will be merged into the original project, and we can refer to it again.
This fixes #302 by temporarily forking `detect-port`. Hopefully this fix will be merged into the original project, and we can refer to it again.
This should be fixed in the new version. Can you please verify? |
Thank you so much! I will revert my commit and bump the version so we use |
Working for me 👍 |
Fix travis build
Node: v5.4.1
OS: OS X 10.11.5 / Darwin Stevens-MBP 15.5.0 Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64
I've narrowed it down to the
detect-port
library used. I tested out the library's CLI and got similar results.Added a timer to the start script:
Result of running
npm run start
The text was updated successfully, but these errors were encountered: