Add image optimization #10572
Closed
Add image optimization #10572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanthratna
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
suyundukov
suggested changes
Feb 17, 2021
sumanthratna
force-pushed
the
image-optimization
branch
from
fb7c92f to
fff235f
Compare
`npm install image-minimizer-webpack-plugin@^1.0.0 imagemin-gifsicle imagemin-jpegtran imagemin-optipng imagemin-svgo` NOTE: when CRA upgrades to Webpack 5, update image-minimizer-webpack-plugin to v2.
Co-authored-by: Ian Schmitz <[email protected]> Co-authored-by: jasonwilliams <[email protected]> Co-authored-by: Joseph Atkins-Turkish <[email protected]> Co-authored-by: e-w-h <[email protected]> Co-authored-by: Shamprasad RH <[email protected]> Co-authored-by: James George <[email protected]>
sumanthratna
force-pushed
the
image-optimization
branch
from
8b7c5a0 to
1209d6d
Compare
|
I messed up the git history so I'm closing in favor of #11279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first step towards implementing #10467
This PR implements image optimization via Webpack. All image optimizations are lossless; if a user wants to customize optimization then they should either eject or optimize images themselves without ejecting.
I have added a unit test (which passes)—the unoptimized image is ~66.5 KB while the optimized image is ~32.1 KB.