Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return proper exit code in bin/react-scripts via spawnSync (#252) #256

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

weisjohn
Copy link
Contributor

This fixes #252

@ghost
Copy link

ghost commented Jul 28, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost ghost added the CLA Signed label Jul 28, 2016
@vjeux
Copy link
Contributor

vjeux commented Jul 28, 2016

Code looks good, waiting for travis to complete

@ghost
Copy link

ghost commented Jul 28, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@vjeux vjeux merged commit 40b0ac9 into facebook:master Jul 28, 2016
Jiansen added a commit to Jiansen/create-react-app that referenced this pull request Jul 28, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-zero exit codes for npm run-script build?
2 participants