Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated stack from thread-loader #3847

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Remove duplicated stack from thread-loader #3847

merged 1 commit into from
Jan 18, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Jan 18, 2018

No description provided.

@Timer Timer added this to the 2.0.0 milestone Jan 18, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 18, 2018

Do we understand why we get it? Is it just due to error re-wrapping?

@Timer
Copy link
Contributor Author

Timer commented Jan 18, 2018

It's intentionally added, but we'd only ever be interested in the top error stack.
See https://github.com/webpack-contrib/thread-loader/blob/master/src/WorkerPool.js#L189.

@Timer Timer mentioned this pull request Jan 18, 2018
Closed
@Timer Timer merged commit f071986 into facebook:next Jan 18, 2018
@Timer Timer deleted the remove-thread-loader-stack branch January 18, 2018 03:05
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
@Timer @akstuhl
Remove duplicated stack from thread-loader (facebook#3847)
44b216b
@marcofugaro marcofugaro mentioned this pull request May 8, 2018
Merged
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @gaearon @facebook-github-bot