Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to PWA section of docs #5664

Closed
wants to merge 1 commit into from
Closed

Conversation

angie
Copy link

@angie angie commented Nov 1, 2018

Fix link to PWA docs until #5536 is addressed.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu
Copy link
Contributor

iansu commented Nov 14, 2018

I appreciate your trying to fix this. However, this doesn't really solve the problem since these links are in the template. This would help for new apps but there are millions of existing apps out there that will still have the old bit.ly links in them. To address that I've created this PR: #5808

@angie
Copy link
Author

angie commented Nov 14, 2018

I hadn't thought of existing apps @iansu 😅. I'll close this.

@angie angie closed this Nov 14, 2018
@iansu
Copy link
Contributor

iansu commented Nov 14, 2018

Yeah, it's a bit of a weird situation with those files being copied into people's apps. Thanks for your contribution though!

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants