Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append title element to SVG component via title prop #7118

Merged
merged 4 commits into from
Jul 15, 2019
Merged

Append title element to SVG component via title prop #7118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77676f0
fixes: #7103 - append title element to SVG component
sudkumar May 27, 2019
f6b96cc
update(package): update the @svgr/webpack from 4.2.0 to 4.3.0 to get …
sudkumar May 28, 2019
f361c4f
chore(@svgr/webpack): from 4.3.0 to 4.3.1 to get the title fix
sudkumar Jul 2, 2019
8a30635
Merge branch 'master' into svg_title
sudkumar Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Bug report
about: Create a report to help us improve
labels: "issue: bug"
labels: 'issue: bug'
---

<!--
Expand Down Expand Up @@ -59,7 +59,6 @@ labels: "issue: bug"

(Write your answer here.)


### Which terms did you search for in User Guide?

<!--
Expand All @@ -79,7 +78,6 @@ labels: "issue: bug"

(Write your answer here if relevant.)


### Environment

<!--
Expand All @@ -96,7 +94,6 @@ labels: "issue: bug"

(paste the output of the command here.)


### Steps to reproduce

<!--
Expand All @@ -106,10 +103,9 @@ labels: "issue: bug"

(Write your steps here:)

1.
2.
3.

1.
2.
3.

### Expected behavior

Expand All @@ -121,7 +117,6 @@ labels: "issue: bug"

(Write what you thought would happen.)


### Actual behavior

<!--
Expand All @@ -132,7 +127,6 @@ labels: "issue: bug"

(Write what happened. Please add screenshots!)


### Reproducible demo

<!--
Expand All @@ -153,7 +147,6 @@ labels: "issue: bug"

(Paste the link to an example project and exact instructions to reproduce the issue.)


<!--
What happens if you skip this step?

Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/proposal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Proposal
about: Suggest an idea for improving Create React App
labels: "issue: proposal"
labels: 'issue: proposal'
---

### Is your proposal related to a problem?
Expand Down Expand Up @@ -32,7 +32,7 @@ labels: "issue: proposal"
### Additional context

<!--
Is there anything else you can add about the proposal?
Is there anything else you can add about the proposal?
You might want to link to related issues here, if you haven't already.
-->

Expand Down
3 changes: 2 additions & 1 deletion packages/react-scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,8 @@ module.exports = function(webpackEnv) {
{
loaderMap: {
svg: {
ReactComponent: '@svgr/webpack?-svgo,+ref![path]',
ReactComponent:
'@svgr/webpack?-svgo,+titleProp,+ref![path]',
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"types": "./lib/react-app.d.ts",
"dependencies": {
"@babel/core": "7.4.3",
"@svgr/webpack": "4.2.0",
"@svgr/webpack": "4.3.1",
"@typescript-eslint/eslint-plugin": "1.10.2",
"@typescript-eslint/parser": "1.10.2",
"babel-eslint": "10.0.1",
Expand Down