-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navbar line break in docusaurus #7831
Conversation
That was intentional though for small screen. cc @yangshun If this PR is applied, for small screen you'll see discrepancy like this |
Ah, thats not good enough. Are the breakpoint variables available for custom.css or is there any other way to solve it? |
I dont think its intentional though because in chrome its correct (1 line) in desktop and line split in mobile. |
@endiliey I did notice this on mobile as well. It would be nice if the search input was maybe just the magnifying glass icon in this case. Clicking it could expand it in some way to allow text entry. Just a thought. |
We already did that. For devices with viewport width less than 360px, the searchbar is replaced with a search icon. Example: https://user-images.githubusercontent.com/17883920/62456721-4b285f00-b7a3-11e9-930b-0542ad3f7fdf.gif I guess we need to adjust the media query. WDYT @yangshun on the line break ? Its infima (another facebookincubator project) css |
@endiliey any idea on how to solve this with the latest docusaurus beta or should we just close this one? |
we use a css framework called infima (still in facebookincubator). I think @yangshun is the best person to answer this |
The new docusaurus 2 site is gorgeous. I noticed a line break in the navbar in safari 13. I didn't manage to sort out why it happens. Putting in
Create React App
on the official docusaurus website didn't break the line (middle screenshot below). Right now Im not sure whatever it's an issue inbootstrap
ordocusaurus
I ended up fixing it with
white-space: nowrap
I also tried:
It's a minor but it makes it looks smoother.
ping @endiliey