fix(v2): remove hashbang when click on collapsed item

facebook · Nov 15, 2019 · 8d5f64d · 8d5f64d
1 parent a65a57b
commit 8d5f64d
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/docusaurus-theme-classic/src/theme/DocSidebar/index.js b/packages/docusaurus-theme-classic/src/theme/DocSidebar/index.js
@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import React, {useState} from 'react';
+import React, {useState, useCallback} from 'react';
 import classnames from 'classnames';
 
 import Link from '@docusaurus/Link';
@@ -27,6 +27,11 @@ function DocSidebarItem({item, onItemClick, collapsible}) {
     setCollapsed(item.collapsed);
   }
 
+  const handleClickItem = useCallback(e => {
+    e.preventDefault();
+    setCollapsed(state => !state);
+  });
+
   switch (type) {
     case 'category':
       return (
@@ -42,9 +47,7 @@ function DocSidebarItem({item, onItemClick, collapsible}) {
                 'menu__link--active': collapsible && !item.collapsed,
               })}
               href="#!"
-              onClick={
-                collapsible ? () => setCollapsed(!collapsed) : undefined
-              }>
+              onClick={collapsible ? handleClickItem : undefined}>
               {label}
             </a>
             <ul className="menu__list">