fix: do not hardcode siteConfig path #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not hardcode path in require to siteConfig
This was referenced Dec 7, 2018
|
Deploy preview for docusaurus-preview ready! Built with commit 4e42759 |
I think the test may be wrong too.
|
Unless I am totally missing something here, this should be the proper fix to the path issue. |
|
This is because on test. process.cwd() is actually not |
|
I'm gonna patch this PR and make |
|
@endiliey - I trust you 👍 |
endiliey
changed the title
endiliey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix broken build
Fixes #1149
Have you read the Contributing Guidelines on pull requests?
Yes, I helped write them.
Test Plan
Local Testing
Related PRs
#1143