Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: showcase user Quix #1510

Merged
merged 2 commits into from
May 27, 2019
Merged

docs: showcase user Quix #1510

merged 2 commits into from
May 27, 2019

Conversation

nickbui729
Copy link
Contributor

Motivation

This is my first attempt at an open source contribution. I've learned a lot doing this, especially with setting up the repo for pushing! Very awesome stuff! Thank you for setting this up for new contributors like me. Please let me know if any of my documentation convention is not correct.

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Yes

Test Plan

I have added the correct links to the websites as requested by the guidelines and the users. The logos were tested by checking to see if they were rendered on the website. The links where tested by clicking on them.

Related PRs

Link to logo permissions for projects:

ZIO:
zio/zio#878

QUIX:
wix-incubator/quix#77

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 23, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 4c81896

https://deploy-preview-1510--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 23, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 4c81896

https://deploy-preview-1510--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some issues I found:

  1. You have to sign the CLA before I can merge a PR from you.
  2. The current Zio website doesn't seem to be using Docusaurus. Seems to be on Jekyll.
  3. It'll be better to separate one PR per new user.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 26, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nickbui729 nickbui729 changed the title docs: showcase user Zios, Quix docs: showcase user Quix May 26, 2019
@nickbui729
Copy link
Contributor Author

  1. I just signed the CLA.
  2. The Zios website in fact does run in Jekyll, therefore I removed it from the users page
  3. Edited the name of the pull request to represent only Quix

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you remove the zio.png logo file also?

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the Zio logo on your behalf.

@yangshun yangshun merged commit 9b2ff32 into facebook:master May 27, 2019
tusharf5 pushed a commit to tusharf5/Docusaurus that referenced this pull request May 27, 2019
* added users

* removed zios from users
@nickbui729 nickbui729 deleted the users branch May 27, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants