-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: showcase user Quix #1510
docs: showcase user Quix #1510
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
1 similar comment
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Deploy preview for docusaurus-2 ready! Built with commit 4c81896 |
Deploy preview for docusaurus-preview ready! Built with commit 4c81896 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Some issues I found:
- You have to sign the CLA before I can merge a PR from you.
- The current Zio website doesn't seem to be using Docusaurus. Seems to be on Jekyll.
- It'll be better to separate one PR per new user.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could you remove the zio.png logo file also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the Zio logo on your behalf.
* added users * removed zios from users
Motivation
This is my first attempt at an open source contribution. I've learned a lot doing this, especially with setting up the repo for pushing! Very awesome stuff! Thank you for setting this up for new contributors like me. Please let me know if any of my documentation convention is not correct.
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Yes
Test Plan
I have added the correct links to the websites as requested by the guidelines and the users. The logos were tested by checking to see if they were rendered on the website. The links where tested by clicking on them.
Related PRs
Link to logo permissions for projects:
ZIO:
zio/zio#878
QUIX:
wix-incubator/quix#77
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)