Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translateable strings and allow overriding of english strings #158

Merged
merged 1 commit into from
Oct 23, 2017
Merged

add translateable strings and allow overriding of english strings #158

merged 1 commit into from
Oct 23, 2017

Conversation

rickyvetter
Copy link
Contributor

@rickyvetter rickyvetter commented Oct 23, 2017

This adds "Translate this Doc" and "Edit this Doc" to the list of string that can be translated. Also changes how the translations are written so that en.json will overwrite specific translations. This allows for overriding Docusaurus provided strings that a project may not like (for example ReasonReact would like to say "Edit" instead of "Edit this Doc" in English).

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 23, 2017
@ericnakagawa
Copy link
Contributor

LGTM

@JoelMarcey JoelMarcey merged commit 5861354 into facebook:master Oct 23, 2017
@rickyvetter rickyvetter deleted the translateLinks branch October 23, 2017 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants