Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v2): demonstrate highlighting with comments #2457

Closed
wants to merge 1 commit into from
Closed

docs(v2): demonstrate highlighting with comments #2457

wants to merge 1 commit into from

Conversation

elviswolcott
Copy link
Contributor

Motivation

Docs for #2456

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

n/a

Related PRs

#2456

@elviswolcott elviswolcott requested a review from wgao19 as a code owner March 24, 2020 07:01
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 24, 2020
@elviswolcott elviswolcott mentioned this pull request Mar 24, 2020
Merged
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 8356ed1

https://deploy-preview-2457--docusaurus-2.netlify.com

lex111
lex111 reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not document the new feature in a separate PR. Therefore could you move the changes from this PR to #2456, and close it?

@elviswolcott elviswolcott mentioned this pull request Mar 24, 2020
Merged
@elviswolcott
Copy link
Contributor Author

Makes sense.
The current PR template language seems to suggest a separate PR for docs, I don't know if that should be updated. https://github.com/facebook/docusaurus/blob/master/.github/PULL_REQUEST_TEMPLATE.md#related-prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 lex111 left review comments

@wgao19 wgao19 Awaiting requested review from wgao19

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elviswolcott @docusaurus-bot @lex111 @facebook-github-bot