Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): showcase user Tourmaline #2569

Merged
merged 1 commit into from
Apr 9, 2020
Merged

docs(v2): showcase user Tourmaline #2569

merged 1 commit into from
Apr 9, 2020

Conversation

watzon
Copy link
Contributor

@watzon watzon commented Apr 9, 2020

Motivation

To get my recently published docs into the showcase

Have you read the Contributing Guidelines on pull requests?

I sure have!

Test Plan

Well I tested by running the site and making sure it was working. If there are any tests specific to the showcase I'd be happy to amend the PR.

@watzon watzon requested a review from yangshun as a code owner April 9, 2020 18:20
@facebook-github-bot
Copy link
Contributor

Hi @watzon!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 6043249

https://deploy-preview-2569--docusaurus-2.netlify.com

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 9, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 9, 2020
@lex111 lex111 merged commit 2510d3f into facebook:master Apr 9, 2020
@lex111
Copy link
Contributor

lex111 commented Apr 9, 2020

@watzon thanks for adding your project to our showcase!

@yangshun yangshun changed the title Add Tourmaline to the showcase docs(v2): showcase user Tourmaline Apr 9, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants