Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first set of docusaurus-build tests using Jest #259

Merged
merged 8 commits into from
Dec 18, 2017
Merged

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Dec 5, 2017

This is an initial attempt at testing that the Docusaurus site itself is built correctly.

Test Plan

$ yarn
$ yarn test

screen shot 2017-12-06 at 10 37 07 am

@hramos hramos force-pushed the jests branch 2 times, most recently from 832e7ed to f06d24f Compare December 5, 2017 18:36
@JoelMarcey
Copy link
Contributor

@hramos We definitely should do this. I always thought Jest might be helpful here, but was unsure how to get it implemented.

Is the goal to NOT merge this PR until we add the full list of Jest tests in your TODO list?

@hramos
Copy link
Contributor Author

hramos commented Dec 6, 2017

We don't have to wait until all the tests are in place - I've moved the list to #263. Right now, I'd like to get some feedback on whether this is the right approach.

@hramos hramos changed the title [WIP] Add tests [WIP] Add docusaurus-build tests Dec 6, 2017
@JoelMarcey JoelMarcey changed the title [WIP] Add docusaurus-build tests Add first set of docusaurus-build tests using Jest Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants