fix(v2): Add all webpack module aliases to type declaration file #2687
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit f1242b1 |
|
@SamChou19815 will your PR solve this issue? #2675 |
Yes, but we will need another publish to include this change. |
|
@SamChou19815 excellent, I will make a new release of course! |
lex111
approved these changes
Apr 28, 2020
|
@SamChou19815 thank you! |
|
@lex111 have all of these changes been published? I only have the
|
|
@Ehesp yes, I published a new version of D2 - |
|
Ah thanks - that version wasn't showing on npm - updated and works. Thanks! |
yechs
added a commit
to Computerization/computerization.github.io
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With these additions, all typescript red squiggly lines will be gone once user install
@docusaurus/module-type-aliasesand create atypes.d.tsthat references@docusaurus/module-type-aliases.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
types.d.tswith content/// <reference types="@docusaurus/module-type-aliases" />to the root ofpackages/docusaurus-theme-classic.@docusaurus/...,styles.module.cssandstyles.cssno longer has red squiggly lines.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)