Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): set proper font for live editor #2835

Merged
merged 1 commit into from
May 29, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 29, 2020

Motivation

Fix an unexpected regression due to facebookincubator/infima@dfb1da4

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After
screenshot_21 screenshot_20

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label May 29, 2020
@lex111 lex111 added this to the v2.0.0-alpha.57 milestone May 29, 2020
@lex111 lex111 requested a review from yangshun as a code owner May 29, 2020 09:55
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 29, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really see the difference here but ok

@yangshun yangshun merged commit e57294f into master May 29, 2020
@lex111
Copy link
Contributor Author

lex111 commented May 29, 2020

The font size in live editor is very small compared to regular code block, just see the screenshots in Test Plan.

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 556a637

https://deploy-preview-2835--docusaurus-2.netlify.app

@lex111 lex111 deleted the lex111/live-editor-font-issue branch May 29, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants