fix(v2): website feedback page hydration bug #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 72d0f96 |
slorber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2828
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
When accessed directly with a "deep link", there should not be any hydration problem in feedback,
https://{host}/feedback/p/api-documentation-swaggerMost render the feedback page accordingly.
Moreover, I added the metacharacter
\bto the regex expression, so it renders the not found page when accessing an incorrect feedback page. This is the current behavior,https://v2.docusaurus.io/feedback1/p/api-documentation-swaggerrenders,Expected render,
Related PRs