docs(v2): Added drone.io publish docs #3491 #3492
Conversation
|
Hi @aakhtar3! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
CLA has been signed |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit de29ab5 |
|
Thanks. CLA bot takes time sometimes ;) @aakhtar3 you modified the docs of v1, not v2 (https://github.com/facebook/docusaurus/edit/master/website/docs/deployment.md). It seems like your intention was to modify v2 doc, as it's the most "future-proof" version. (will try to make these repo paths less confusing so that it's clearer that you edit v1 or v2 docs) |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@slorber Made the change |
|
That seems not exactly what you want right? Looks like your instructions are related to GH pages, not Netlify https://deploy-preview-3492--docusaurus-2.netlify.app/classic/docs/deployment/#deploying-to-netlify
|
|
@slorber Its moved up under the GH pages |
|
LGTM thanks :) |
slorber
added
the
pr: documentation
|
@slorber Where could I make this change for v1? |
Motivation
Added support for drone.io
Have you read the Contributing Guidelines on pull requests?
Yes