Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v2): add npm2yarn to typescript install command #3750

Merged
merged 1 commit into from
Nov 14, 2020
Merged

docs(v2): add npm2yarn to typescript install command #3750

merged 1 commit into from
Nov 14, 2020

Conversation

davidjgoss
Copy link
Contributor

Motivation

Make the "TypeScript Support" doc page for V2 consistent in providing both npm and yarn command examples.

Have you read the Contributing Guidelines on pull requests?

Yes.

@facebook-github-bot
Copy link
Contributor

Hi @davidjgoss!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Nov 14, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit bd22f71

https://deploy-preview-3750--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 14, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

2 similar comments
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

lex111
lex111 approved these changes Nov 14, 2020
View reviewed changes
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lex111 lex111 merged commit bb64f68 into facebook:master Nov 14, 2020
@lex111
Copy link
Contributor

lex111 commented Nov 14, 2020

@davidjgoss thanks!

@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@lex111 lex111 added documentation The issue is related to the documentation of Docusaurus pr: documentation This PR works on the website or other text documents in the repo. and removed documentation The issue is related to the documentation of Docusaurus labels Nov 17, 2020
@davidjgoss davidjgoss deleted the typescript-support-npm2yarn branch April 8, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 lex111 approved these changes

@slorber slorber Awaiting requested review from slorber

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
v2.0.0-alpha.68
Development

Successfully merging this pull request may close these issues.
3 participants
@davidjgoss @facebook-github-bot @lex111