Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): remove useless stylelint-copyright peerDependency #3800

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 23, 2020

Motivation

The dep stayed on older version alpha 66 after this change: #3766 (comment)

But it seems declaring the peer deps here is not required, so maybe we can just remove it?

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 23, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 23, 2020
@netlify
Copy link

netlify bot commented Nov 23, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 81fb538

https://deploy-preview-3800--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: +18 B (0%)

Total Size: 153 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -2 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.86 kB +2 B (0%)
website/build/main.********.js 109 kB +18 B (0%)
website/build/styles.********.css 17.3 kB 0 B

compressed-size-action

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it looks like it's really unnecessary.

@lex111 lex111 merged commit e949f4c into master Nov 23, 2020
@lex111
Copy link
Contributor

lex111 commented Nov 23, 2020

@slorber thanks!

@lex111 lex111 added this to the v2.0.0-alpha.69 milestone Nov 23, 2020
@slorber slorber deleted the slorber/revert-deps-change branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants